Author Topic: Macro fails, but script works? (Read 3113 times)

Jerros · « **on:** June 28, 2011, 11:18:23 am »

This... is odd, I'm using AppDev (DWedit ?) for creating apps, but it's crashing when changing a certain macro.
This still works fine:

Code: [Select]

#define	N1_R1		CALL	Something1
#defcont	\	CALL	New1
#define	N2_R1		CALL	Something1
#defcont	\	CALL	New2
#define	N3_R1		CALL	Something1
#defcont	\	CALL	New3
#define	N4_R1		CALL	Something1
#defcont	\	CALL	New4

But as soon as I add one more:

Code: [Select]

(...)
#define	N4_R1		CALL	Something1
#defcont	\	CALL	New4
#define	N5_R1		CALL	Something1
#defcont	\	CALL	New5

It crashes. It's not the "New5" thingy, since it does the same for 6 and up, and when removing one earlier macro it does work fine with "5" and up. Now, this could indicate that the maximum number of macro's has been reached, however this is not the case. It can hold up to 1000 macros, and it's still far from. Plus, when adding many other macros it still works like a charm.
And what's even weirder, when using the macro to run a CALL containing both lines, line this:

Code: [Select]

#define	N6_R1	CALL	DoBoth
(...)
DoBoth:
     CALL     Something1
     CALL     New6
ret

it works fine again. Can go all the way from 1-w/e with that. (Though I guess it's faster and shorter to use the two CALLs in a row, rather than making a small routing doing both CALLs, right?). It's not the scripts which are being called either - with any other macro substituting for those it works fine. Am I missing something?

Thanks in advance!

BuckeyeDude · « **Reply #1 on:** June 30, 2011, 07:19:00 am »

My guess is its a bug in TASM. One thing to check would be stupid things like your line ending, making sure you're not redefining something, etc. How #defines work are whatever text is within the define is essentially copied and replaced whenever you use it. Also I'm obligated to pimp SPASM as a compatible TASM-replacement, especially if you want to be able to do more with macros.

You're correct doing call x \ call x is faster as it removes the 17 or whatever clocks of doing the other call, but if you're calling any of these a lot then your DoBoth will save you some space (3 bytes per call assuming you have more than 2 calls). My reccomendation would be to go with your original macros unless you're really pressed for space, which I highly doubt you are.

Jerros · « **Reply #2 on:** June 30, 2011, 01:01:26 pm »

Thank you, I'll check out SPASM then, though AppDev worked fine... or at least it used to. ><
So it's faster/less bytes to do:

Code: [Select]

     CALL     Meh1
     CALL     Meh2

than:

Code: [Select]

(...)
     CALL     LAbel
(...)

LAbel:
     CALL     Meh1
     CALL     Meh2
ret

when needing to use Meh1 --> Meh2 in a row a couple of times?

As for the space issue, the app is already 5 pages big, and wel... as usual, the smaller the better.

Though if the other way's better then I'll stick to that.

the_mad_joob · « **Reply #3 on:** July 11, 2011, 02:47:50 am »

With tasm, the content of a macro definition cannot exceed 511 characters (useless spaces|tabs included).
If you have a little more characters, tasm will output a typical error message.
If you have a lot more characters, tasm will simply crash (not handled at all).

In the case you have lots of identical contiguous bytes|words to declare, the .fill directive can help.

Author Topic: Macro fails, but script works? (Read 3113 times)

Jerros

Macro fails, but script works?

BuckeyeDude

Re: Macro fails, but script works?

Jerros

Re: Macro fails, but script works?

the_mad_joob

Re: Macro fails, but script works?