« previous next »
Pages: [1]   Go Down

Author Topic: [C#] Scan-line flood-fill  (Read 8397 times)

0 Members and 3 Guests are viewing this topic.

Offline BlakPilar

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 734
  • Rating: +44/-1
    • View Profile
[C#] Scan-line flood-fill
« on: March 02, 2012, 08:38:50 pm »
A while ago on the IRC I asked about flood fill routines, and Runer was kind enough to point me to Lode's recursive scan-line routine. I converted it over to C# and tried to get it to work, but I haven't had any success. Note: I only use two colors- black and white.

Here's the PasteBin: http://pastebin.com/WQNjXm4x

Whenever I flood-fill in an empty region it works fine, but once it reaches some other area, it stops. And when I fill inside of a region, it only "floods" down from where I click (see attachment).

Anyone have an idea?
Logged

Offline jacobly

  • LV5 Advanced (Next: 300)
  • *****
  • Posts: 205
  • Rating: +161/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #1 on: March 02, 2012, 08:52:08 pm »
One thing I noticed is that current is not updated before every while loop, which is probably what is causing it to stop. More importantly, you fill the scanline before you scan the pixels adjacent to the scanline, so you can no longer use the pixels in the scanline to know how far to go. The easiest thing I can think to do is to record the lowest and highest values of y while you fill the scanline, and later only look at adjacent pixels up to those values.
Logged

Offline BlakPilar

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 734
  • Rating: +44/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #2 on: March 02, 2012, 09:27:14 pm »
After you mentioned it, I had thought it was just because I wasn't updating current, so I went with a more direct translation. However, now no matter what it just fills everything in <_<

(PasteBin link is still http://pastebin.com/WQNjXm4x)
Logged

Offline jacobly

  • LV5 Advanced (Next: 300)
  • *****
  • Posts: 205
  • Rating: +161/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #3 on: March 02, 2012, 09:28:59 pm »
Quote from: jacobly on March 02, 2012, 08:52:08 pm
--snip-- More importantly, you fill the scanline before you scan the pixels adjacent to the scanline, so you can no longer use the pixels in the scanline to know how far to go. The easiest thing I can think to do is to record the lowest and highest values of y while you fill the scanline, and later only look at adjacent pixels up to those values.
:)
Logged

Offline BlakPilar

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 734
  • Rating: +44/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #4 on: March 02, 2012, 09:32:29 pm »
What I got from the original code is after it fills in a scanline it retraces it (while (y1 < buffer.Height && areColorValuesEqual(buffer.GetPixel(x, y1), end))) while checking pixels to the left or right (if (x < buffer.Width - 1 && areColorValuesEqual(buffer.GetPixel(x +/- 1, y1), start))). So technically doesn't it keep track of the highest and lowest for you?
« Last Edit: March 02, 2012, 09:32:46 pm by BlakPilar »
Logged

Offline jacobly

  • LV5 Advanced (Next: 300)
  • *****
  • Posts: 205
  • Rating: +161/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #5 on: March 02, 2012, 09:40:41 pm »
Imagine:
-----
| # |
|###|
|   |
| X |
|   |
|###|
| # |
-----

First, it fills the scanline.
-----
| # |
|###|
| # |
| # |
| # |
|###|
| # |
-----

Then it scans the (now longer) black scanline, and fills adjacent areas.
-----
|###|
|###|
|###|
|###|
|###|
|###|
|###|
-----

Which I don't believe is what you want. :)

Edit: (btw, I'm just going by what your code says, I haven't looked at the algorithm.)
« Last Edit: March 02, 2012, 09:42:44 pm by jacobly »
Logged

Offline BlakPilar

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 734
  • Rating: +44/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #6 on: March 02, 2012, 09:51:47 pm »
Ok, but if I have something like this, shouldn't it work the way it's supposed to?

---------
|       |
| ##### |
| #   # |
| # X # |
| #   # |
| ##### |
|       |
---------

---------
|       |
| ##### |
| # # # |
| # # # |
| # # # |
| ##### |
|       |
---------

---------
|       |
| ##### |
| ### # |
| ### # |
| ### # |
| ##### |
|       |
---------

---------
|       |
| ##### |
| ##### |
| ##### |
| ##### |
| ##### |
|       |
---------
Logged

Offline BlakPilar

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 734
  • Rating: +44/-1
    • View Profile
Re: [C#] Scan-line flood-fill
« Reply #7 on: March 03, 2012, 12:15:39 pm »
Never mind. I was thinking about it all last night, and I finally understood what you meant. I did what you said, and it works ;D thank you! (I've also updated the PasteBin if anyone wants to see what it looks like now.)
Logged
Pages: [1]   Go Up
« previous next »