« previous next »
Pages: 1 2 [3] 4   Go Down

Author Topic: Mistakes made in the ASM tutorials  (Read 36075 times)

0 Members and 3 Guests are viewing this topic.

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #30 on: March 06, 2011, 07:35:05 pm »
Quote from: Lesson 7 Page 11
T-States: Byte Storage:
JR—12 if condition is true 2 Bytes
7 if condition is true 2 Bytes
JP – 10 no matter what
Which is it 12 or 7 if the condition is true?
Which one is it if it is false?
« Last Edit: March 20, 2011, 11:19:01 pm by ralphdspam »
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #31 on: March 06, 2011, 10:01:55 pm »
Oops: 7 T-States if condition is false
Logged

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #32 on: March 08, 2011, 10:25:54 pm »
Quote from: Lesson 8 Page 13
#include “ti83plus.inc”
.org 40339
.db t2ByteTok, tAsmCmp
B_CALL _ClrLCDFull
ld a, 1
cp 1 ; If A = 1
jr z, DisplayNumber1 ; A – 1 = 0. So, if A = 1, CP 1 will
; give A – 1 = 1 – 1 = 0, therefore the
; zero (Z) flag will be set
cp 2
ret z ; If A = 2, end the program
DisplayNumber1:
ld h, 0
ld l, a ; Remember that CP does not affect A. A still equals 1.
B_CALL _DispHL
B_CALL _getKey
B_CALL _ClrCLDFull
ret
I think should be B_CALL _ClrLCDFull
Logged
+1/-0 karm for this message
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #33 on: March 08, 2011, 10:37:20 pm »
Yeah, you're right, and that one's weird because I usually test my programs
Logged

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #34 on: March 08, 2011, 10:54:24 pm »
Quote from: Lesson 8 Page 14
cp 27 ; If A = 1
I don't think it is the equivalent of "If A = 1".
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #35 on: March 08, 2011, 11:51:30 pm »
Nope, it's not.  Keep em coming!
Logged

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #36 on: March 12, 2011, 12:25:08 am »
Quote from: Lesson 8 Page 14
Load_Player_Data:
ld b, (hl) ; In a perfect world, h contains the ram address to load from
inc h
ld c, (hl)
inc hl
ld d, (hl)
inc hl
ld e, (hl)
inc hl
ld a, (hl)
ret
Did you mean "inc hl"?

This too:
Quote from: Lesson 8 Page 16
Text:
.db “Hello World”, “This is my string,” 224, 65, 67, 67, 65, etc.

This one is really knit picky. :P
« Last Edit: March 20, 2011, 11:22:22 pm by ralphdspam »
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #37 on: March 12, 2011, 12:38:24 am »
I don't know what is wrong with the second one, but definitely inc hl instead of inc h.
Logged

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #38 on: March 12, 2011, 12:41:29 am »
For the second one, I thought it should be
.db "Hello World", "This is my string", 224, 65, 67, 67, 65, etc.

In the lesson, it was:
Quote
.db "Hello World", "This is my string," 224, 65, 67, 67, 65, etc.

I don't know. I am supposed to be the one learning. :P
« Last Edit: March 12, 2011, 12:42:24 am by ralphdspam »
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #39 on: March 12, 2011, 12:52:46 am »
Oh, well you're correct there, the comma should be outside
« Last Edit: March 12, 2011, 12:53:00 am by Hot_Dog »
Logged

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #40 on: March 12, 2011, 01:04:35 am »
Sorry for the double post, but I've got to say this: thanks for catching the errors, ralphdspam, I like it for two reasons:

1. Readers will not have so many errors
2. It shows that you are understanding asm from reading these tutorials, which is what I was aiming for
Logged
+2/-0 karm for this message

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #41 on: March 15, 2011, 11:13:31 pm »
Quote from: Lesson 11 Page 3
B_CALL _VPutSN
Displays a string specified by HL. The string does not end in a
zero. Instead, the number of characters to display is stored in
register B.
Examples: LD HL, String
LD B, 11
B_CALL PutS
String:
.db “Hello World”

Is that supposed to be B_CALL _VPutSN?
I am kind of confused. ???

EDIT: I could not find this command in the new tutorials.  ???
« Last Edit: March 20, 2011, 11:26:56 pm by ralphdspam »
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #42 on: March 16, 2011, 12:00:30 am »
Quote from: ralphdspam on March 15, 2011, 11:13:31 pm
Quote from: Lesson 11 Page 3
B_CALL _VPutSN
Displays a string specified by HL. The string does not end in a
zero. Instead, the number of characters to display is stored in
register B.
Examples: LD HL, String
LD B, 11
B_CALL PutS
String:
.db “Hello World”

Is that supposed to be B_CALL _VPutSN?
I am kind of confused. ???

No need to be confused.  That is indeed another typo
Logged

Offline ralphdspam

  • LV8 Addict (Next: 1000)
  • ********
  • Posts: 841
  • Rating: +38/-1
  • My name is actually Matt.
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #43 on: March 16, 2011, 12:31:01 am »
Also, I think:
Quote from: Lesson 11 Page 13
B_CALL _ClrLCDFull
     ld d, MainMenuItem1X ; Stores the X position for the menu
     ld e, MainMenuItem1Y ; Stores the starting Y position for the menu
should be:
Code: [Select]
     B_CALL _ClrLCDFull
     ld d, MainMenuItem1X ; Stores the X position for the menu
     ld e, MainMenuItem1Y ; Stores the starting Y position for the menu
EDIT: This is not in the new tutorials. 
« Last Edit: March 20, 2011, 11:27:59 pm by ralphdspam »
Logged
ld a, 0
ld a, a

Offline Hot_Dog

  • Project Author
  • LV12 Extreme Poster (Next: 5000)
  • *
  • Posts: 3006
  • Rating: +445/-10
    • View Profile
Re: Mistakes made in the ASM tutorials
« Reply #44 on: March 16, 2011, 12:33:55 am »
Oh, I missed that tab, didn't I  :banghead:
« Last Edit: March 16, 2011, 12:34:17 am by Hot_Dog »
Logged
Pages: 1 2 [3] 4   Go Up
« previous next »